[pull] master from mattermost:master - #911
Merged
Merged
Conversation
) * [MM-69748] Add Hide Archived toggle to Browse Channels modal Archived channels previously appeared mixed in with active channels in the Browse Channels modal under the default "All channel types" filter (most visibly in search results), with no way to filter them out. Add a "Hide Archived" checkbox next to "Hide Joined" that hides archived channels by default. The toggle is backed by a persisted preference and is not shown when the explicit "Archived channels" filter is selected. Co-authored-by: mattermost-code <matty-code@mattermost.com> * [MM-69748] Add tests for Hide Archived toggle in Browse Channels Cover the default-hidden behavior, toggling to show archived channels, the explicit Archived filter override, preference persistence, and the checkbox being hidden on the Archived filter. Co-authored-by: mattermost-code <matty-code@mattermost.com> * [MM-69748] Strengthen Hide Archived tests per review Add non-search browse-list coverage for getActiveChannels in both directions, assert only archived rows are filtered from search, and query the checkbox by accessible label. Co-authored-by: mattermost-code <matty-code@mattermost.com> * Fix archived channel leak/duplication in Browse Channels filters - Exclude archived private channels from the private channels selector so they no longer bypass the Hide Archived toggle or duplicate with the archived list. - Fold archived channels back into the Public/Private lists (by type) when the toggle is off, matching the All list behavior. - Keep the search Public filter governed by the shared hide-archived block instead of hard-excluding archived public channels. - Add regression tests for the mixed public/private archived scenario. * Satisfy eslint style rules in browse channels changes * Update Browse Channels E2E for Hide Archived default Align Cypress search expectations and Playwright tab/aria snapshots with the new Hide Archived checkbox (on by default). Co-authored-by: mattermost-code <matty-code@mattermost.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: mattermost-code <matty-code@mattermost.com>
…ration setting (#37477) * promote EnableExportDirectDownload to a Cloud-only configuration setting Replace the FeatureFlags.EnableExportDirectDownload feature flag with a FileSettings.EnableCloudExportDirectDownload configuration setting, gated to Mattermost Cloud environments. The /exportlink slash command and the export generate-presigned-url API now require FileSettings.EnableCloudExportDirectDownload to be enabled and a Cloud license. Operators previously enabling the feature via MM_FEATUREFLAGS_ENABLEEXPORTDIRECTDOWNLOAD should transition to MM_FILESETTINGS_ENABLECLOUDEXPORTDIRECTDOWNLOAD. * add tests for Cloud-only export direct download gating Cover the new EnableCloudExportDirectDownload + Cloud-license gate on GeneratePresignURLForExport (app) and the generate-presigned-url API (api4). * add EnableCloudExportDirectDownload to FileSettings type * gate export direct download on Cloud alone, without a configuration setting * Use a bounded HTTP client in export presigned-URL tests http.Get has no total timeout; if MinIO accepts the connection but stalls, these tests can hang until the suite timeout. Co-authored-by: mattermost-code <matty-code@mattermost.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: mattermost-code <matty-code@mattermost.com>
…butes to select fields (#37969) * [MM-70188] Convert the platform, os, browser user agent session attributes to select fields * Update server/public/model/session_attributes.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )